CGA-59w3-cfw7-vhvv

Summary

Uncontrolled Resource Consumption in promhttp

Description

This is the Go client library for Prometheus. It has two separate parts, one for instrumenting application code, and one for creating clients that talk to the Prometheus HTTP API. client_golang is the instrumentation library for Go applications in Prometheus, and the promhttp package in client_golang provides tooling around HTTP servers and clients.

Impact

HTTP server susceptible to a Denial of Service through unbounded cardinality, and potential memory exhaustion, when handling requests with non-standard HTTP methods.

Affected Configuration

In order to be affected, an instrumented software must

• Use any of promhttp.InstrumentHandler* middleware except RequestsInFlight.
• Do not filter any specific methods (e.g GET) before middleware.
• Pass metric with method label name to our middleware.
• Not have any firewall/LB/proxy that filters away requests with unknown method.

Patches

• https://github.com/prometheus/client_golang/pull/962
• https://github.com/prometheus/client_golang/pull/987

Workarounds

If you cannot upgrade to v1.11.1 or above, in order to stop being affected you can:

• Remove method label name from counter/gauge you use in the InstrumentHandler.
• Turn off affected promhttp handlers.
• Add custom middleware before promhttp handler that will sanitize the request method given by Go http.Request.
• Use a reverse proxy or web application firewall, configured to only allow a limited set of methods.

For more information

If you have any questions or comments about this advisory:

• Open an issue in https://github.com/prometheus/client_golang
• Email us at prometheus-team@googlegroups.com